Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new fields to a fieldmap is faster and involves less code duplication. #334

Merged
merged 27 commits into from
Jan 6, 2020
Merged

Adding new fields to a fieldmap is faster and involves less code duplication. #334

merged 27 commits into from
Jan 6, 2020

Conversation

jonathanstegall
Copy link
Member

What does this PR do?

When adding new fields to a fieldmap, this changes the JavaScript so it clones a server-side template instead of duplicating the markup in JavaScript. This makes it easier to change the structure of the fieldmap screen.

How do I test this PR?

  • create a new fieldmap without any data and add multiple fields to it
  • refresh the page and add more fields without resetting the selected objects
  • edit an existing fieldmap by adding more fields to it

@jonathanstegall
update node stuff
118bf65
@jonathanstegall
put the fieldset template into the html so it can be cloned. hide it …
b1a5078 
…if there are already rows present.
@jonathanstegall
we can't fail linting over underscores with the way other people's co…
e39d02d 
…de works
@jonathanstegall
always hide the template row
8dbe298
@jonathanstegall
fix the template row so it works before there is a fieldmap also
78095e0
@jonathanstegall
deprecate wp object description method; rename to fields for what it …
7719342 
…actually does, and add 'fields' to the ajax response accordingly
@jonathanstegall
deprecate the combined method as well
313202b
@jonathanstegall
allow salesforce_object_fields to be ajax method. filter which attrib…
edf92ed 
…utes get returned, in that case.
@jonathanstegall
make adding a new fieldset to the fieldmap driven by a template from …
29a7fcf 
…the server, not from the javascript. also, allow it to regenerate whenever the wp or sf object changes
@jonathanstegall
allow the script to work on a page refresh. also make sure both objec…
06d658c 
…t types have a value.
@jonathanstegall
never delete that template row though
8017ff2
@jonathanstegall
don't replace on existing fieldmaps
8ac45a6
@jonathanstegall
convert post to ajax so we can control the spinners individually
af39cb5
@jonathanstegall
fix spinner markup. also cleanup comments.
000fc54
@jonathanstegall
update the comments, combine the script, etc
6ec64ae
@jonathanstegall
update the changelog
a437542
@jonathanstegall
fix incorrect colspan
f50a654
@jonathanstegall jonathanstegall self-assigned this Jan 5, 2020
@jonathanstegall jonathanstegall added the chore Pull request that does maintenance tasks label Jan 5, 2020
@jonathanstegall jonathanstegall added this to the v1.9.0 milestone Jan 5, 2020
@jonathanstegall jonathanstegall merged commit 28c4e10 into master Jan 6, 2020
@jonathanstegall jonathanstegall deleted the use-clone-for-fieldmap-sets branch January 6, 2020 03:18
@jonathanstegall jonathanstegall mentioned this pull request Jan 6, 2020
Open
@jonathanstegall jonathanstegall changed the title When adding new fields to a fieldmap, we use a server-side template to save code duplication Adding new fields to a fieldmap is faster and involves less code duplication. Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonathanstegall jonathanstegall

Labels
chore Pull request that does maintenance tasks
Projects
None yet
Milestone
v1.9.0
Development

Successfully merging this pull request may close these issues.
1 participant
@jonathanstegall